Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…tecture compatibility
f231691 to
35aad1d
Compare
isalazarbolt
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes native module discovery for Expo and New Architecture (Fabric/TurboModules) consumers. Three issues prevented the SDK from working in
expo run:android/expo run:iosprojects:GooglePayModuleandNetworkingModulewere never registered inBoltReactNativeSdkPackage, soTurboModuleRegistry.get()returned null. Both are legacy (ReactContextBaseJavaModule) modulesand are now registered with
isTurboModule = falseso bridge interop resolves them correctly.BoltApplePayButtonwas missing from the codegen-generatedRCTThirdPartyComponentsProvider, causing an "unimplemented component" error at runtime. Addedios.componentProvidertocodegenConfigin
package.jsonto register it. Also addedRCT_EXTERN_MODULEObjective-C bridge files for theBoltApplePayandBoltNetworkingSwift modules.NativeApplePayButton.android.ts,NativeGooglePayButton.ios.ts) socodegenNativeComponentis never called for a component that doesn't exist on thecurrent platform.
Testing
TurboModuleRegistry.get('BoltGooglePay')→true,TurboModuleRegistry.get('BoltNetworking')→true,TurboModuleRegistry.get('BoltApplePay')→false(expected).TurboModuleRegistry.get('BoltApplePay')→true,TurboModuleRegistry.get('BoltNetworking')→true,TurboModuleRegistry.get('BoltGooglePay')→false(expected).RCTThirdPartyComponentsProvider.mmnow includesBoltApplePayButton → ApplePayButtonComponentViewafterpod install.yarn typecheck,yarn test(115 tests pass), bothyarn example iosandyarn example androidbuild and launch successfully.Security Review
Important
A security review is required for every PR in this repository to comply with PCI requirements.
Security Impact Summary
No security-sensitive changes. This PR only fixes native module registration and Fabric component discovery. It does not touch authentication, authorization, payment flows, user data handling, or external
integrations.